Decode npm-notice heder according to the rfc2047 rule. #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I don't think this is something we need to do because the npm registry is not sending extended ascii characters in its npm-notice headers. They can't start doing it either because even if the npm cli were patched today, millions of folks are running versions of npm that can't display it. As it stands now npm registry implementations are going to have to continue only returning basic ascii as they do today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently server can send only 7-bit ASCII data in
npm-noticeheader.This code change will allow to send any Unicode message. The rfc2047 encoding it is used in similar place (Subject header) in electronic mail. Plain messages that do not contain a very specific phrase
=?[...]?=will not be modified.References
Fixes #37